theforeman
update puma threads tunings
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
- [x] I am okay with my commits getting squashed when you merge this PR.
- [x] I am familiar with the contributing guidelines.
Please cherry-pick my commits into:
- [x] Foreman 3.12/Katello 4.14 (Satellite 6.16)
- [ ] Foreman 3.11/Katello 4.13
- [ ] Foreman 3.10/Katello 4.12
- [x] Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
- [ ] Foreman 3.8/Katello 4.10
- [x] Foreman 3.7/Katello 4.9 (Satellite 6.14)
- [ ] Foreman 3.6/Katello 4.8
- [ ] Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
- We do not accept PRs for Foreman older than 3.5.
The PR preview for e388b42f32da1cbf7fab0b18a812e91f91fc3781 is available at theforeman-foreman-documentation-preview-pr-3248.surge.sh
The following output files are affected by this PR:
- Tuning_Performance/index-foreman-deb.html
- Tuning_Performance/index-foreman-el.html
- Tuning_Performance/index-katello.html
- Tuning_Performance/index-orcharhino.html
- Tuning_Performance/index-satellite.html
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@maximiliankolb Hello, if all looks good to you can I squash all the commits into one?
triage: @Imaanpreet friendly reminder: please rebase to "master" and resolve the merge conflict. diff LGTM
Sorry for delayed changes @maximiliankolb, I have missed your reminder. Thank you for checking.
@Imaanpreet You are requesting cherry picks into a few selected versions only, skipping quite a few in between. Is there a reason for that?
I'd also appreciate it if you provided some more details about this update by filling out the template in the PR description.
Hello Team, I am not sure why I can't get the updates (via emails) and I end up delaying the response :( Yes, please go ahead and updates all the foreman versions as selected above.
Hello @maximiliankolb ! Basically Imaan is the engineer here who measured this stuff. I approve this PR.
Merged to "master" and cherry-picked:
- cff2084d1b..7b0f76d6ff 3.13 -> 3.13
- 86c92c483d..908e6171ea 3.12 -> 3.12
Hello @maximiliankolb ! Basically Imaan is the engineer here who measured this stuff. I approve this PR.
Thanks for the additional ack, @jhutar! To explain: We've been evaluating our review process and part of that is standardizing who we ask to review doc PRs. For example, one suggestion that has been floated around recently is to ask a developer and a QA engineer to review each doc PR, to get multiple perspectives. Thanks for working with us on this PR.
@Imaanpreet Thank you for working on this! I hit a conflict on 3.11 so I didn't cherry-pick there. If you think the update should be included on 3.11 and below, can you please create a separate PR? If you don't think it's necessary, I'm fine with that too.