foreman-documentation icon indicating copy to clipboard operation
foreman-documentation copied to clipboard

Drop mentions of --foreman-proxy-register-in-foreman

Open ekohl opened this issue 1 year ago • 9 comments

By removing mentions of this, it becomes an unsupported feature. This is good because various parts of the documentation assume it's turned on. Users can easily get into unexpected errors way further down the line if they disable this feature.

Where there were explicit instructions to disable it, the text is changed into troubleshooting.

I'd appreciate some feedback on the phrasing of the changed lines.

Please cherry-pick my commits into:

  • [ ] Foreman 3.11/Katello 4.13
  • [ ] Foreman 3.10/Katello 4.12
  • [ ] Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8)
  • [ ] Foreman 3.8/Katello 4.10
  • [ ] Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • [ ] Foreman 3.6/Katello 4.8
  • [ ] Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

ekohl avatar Jun 19 '24 13:06 ekohl

@ehelms @evgeni should we introduce a migration in the installer that resets the answer (so it's turned on) or will that cause more problems than it solves?

ekohl avatar Jun 19 '24 13:06 ekohl

I am cool w/o a migration.

evgeni avatar Jun 19 '24 13:06 evgeni

@ehelms @evgeni should we introduce a migration in the installer that resets the answer (so it's turned on) or will that cause more problems than it solves?

Reset sounds good, and cleaning up the output message that includes it.

ehelms avatar Jun 24 '24 15:06 ehelms

Moving back to draft because it needs some installer work as well before we can proceed.

ekohl avatar Aug 08 '24 11:08 ekohl

Trivial rebase without any content changes just so I could test previews after I made changes there.

ekohl avatar Jan 17 '25 10:01 ekohl

Moving back to draft because it needs some installer work as well before we can proceed.

@ehelms opened https://github.com/theforeman/foreman-installer/pull/1012.

ekohl avatar Feb 24 '25 17:02 ekohl

Moving back to draft because it needs some installer work as well before we can proceed.

@ehelms opened theforeman/foreman-installer#1012.

Good connection! Yea, let's clean all this up.

ehelms avatar Feb 24 '25 18:02 ehelms

Rebased without change, but now the installer is updated. I think this should only go in nightly unless we decide to cherry pick the installer patch as well.

ekohl avatar Feb 24 '25 19:02 ekohl

Trivial rebase done.

ekohl avatar Jun 18 '25 12:06 ekohl

Merged to "master". No cherry-picks necessary according to foreman-installer:

$ git branch --contains cab536317b58d9af129ab369ee5be33a14c4232e
* develop

maximiliankolb avatar Jun 26 '25 12:06 maximiliankolb

Merged to "master". No cherry-picks necessary according to foreman-installer:

Technically I think --contains only looks at merges and won't spot cherry picks because those commits have a different commit ID. https://stackoverflow.com/questions/2922652/git-is-there-a-way-to-figure-out-where-a-commit-was-cherry-picked-from/2937724#2937724 does have some ways. I usually rely on the commit message with git log --all --grep.

ekohl avatar Jun 26 '25 12:06 ekohl

Argh. You're right about cherry-picks. I also assumed that "git branch --contains" would also use remote branches, which it did not. I double checked and it was merged to develop prior to branching 3.15. -> Cherry-picked to "3.15": 29595d3b1b..9f2ae907a0 3.15 -> 3.15

Refs https://github.com/theforeman/foreman-installer/commits/3.15-stable/ image

maximiliankolb avatar Jun 27 '25 06:06 maximiliankolb