foreman-documentation icon indicating copy to clipboard operation
foreman-documentation copied to clipboard

Replace installer-scenario attribute with foreman-installer when possible

Open ekohl opened this issue 1 year ago • 4 comments

On existing installations it's preferable to simply use foreman-installer with the options you wish to change. This replaces it where possible.

Includes https://github.com/theforeman/foreman-documentation/pull/2942.

Please cherry-pick my commits into:

  • [x] Foreman 3.10/Katello 4.12
  • [x] Foreman 3.9/Katello 4.11 (planned Satellite 6.15)
  • [ ] Foreman 3.8/Katello 4.10
  • [ ] Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • [ ] Foreman 3.6/Katello 4.8
  • [ ] Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • [ ] Foreman 3.4/Katello 4.6 (EL8 only)
  • [ ] Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • We do not accept PRs for Foreman older than 3.3.

ekohl avatar Apr 05 '24 16:04 ekohl

The PR preview for 4502f8c6dca2dd0d9623c5d374bd7ebfbf3929cb is available at theforeman-foreman-documentation-preview-pr-2943.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

github-actions[bot] avatar Apr 05 '24 16:04 github-actions[bot]

I am not even sure if changing the scenario is supported.

No. There is code to do so, but it really isn't tested and pretty much guaranteed to be broken in my experience. Just too many small details you need to think about. The code warns you about it as well:

https://github.com/theforeman/kafo/blob/200815048a1c37f94e76682ad1e82a2a47d7807e/lib/kafo/scenario_manager.rb#L160C4-L160C9

ekohl avatar Apr 08 '24 10:04 ekohl

From triage: @ekohl Please rebase to "master"; then we'll re-review and merge.

maximiliankolb avatar May 02 '24 12:05 maximiliankolb

Rebased

ekohl avatar May 16 '24 17:05 ekohl

TODO: cherry-pick to 3.11 too

maximiliankolb avatar Jun 13 '24 12:06 maximiliankolb

Merged to "master" and cherry-picked: fdee78e8a4..229308f96a 3.11 -> 3.11 69e18b64bc..4d360eaa5c 3.10 -> 3.10 1186757273..866538e5a1 3.9 -> 3.9

maximiliankolb avatar Jun 13 '24 15:06 maximiliankolb