foreman-documentation icon indicating copy to clipboard operation
foreman-documentation copied to clipboard

Configure branch protection on stable branches

Open ekohl opened this issue 2 years ago • 3 comments

We should configure the project to not allow force pushes to "X.Y" & "master" branches.

Originally posted by @maximiliankolb in https://github.com/theforeman/foreman-documentation/issues/2644#issuecomment-1864628904

I've created an empty rule for branches matching *.* which should prevent force pushes.

The question is, how far do we want to go with this? We can also mandate a PR, but that prevents cherry picks as we do them today.

ekohl avatar Dec 20 '23 15:12 ekohl

Thanks for creating this rule.

I think preventing force pushes on stable branches is the perfect balance; preventing cherry-picks would really impact my workflow.

IMHO we can close this issue with "done" but lets hear other options too.

maximiliankolb avatar Dec 20 '23 17:12 maximiliankolb

I'll note I didn't test this because of the risk. I'd like to keep it open and discuss this during the next docs meeting.

ekohl avatar Dec 20 '23 17:12 ekohl

I also think preventing force pushes and allowing regular pushes is a good balance.

adamlazik1 avatar Dec 21 '23 11:12 adamlazik1

triage: current state is good as is -> let's close this.

maximiliankolb avatar Nov 07 '24 12:11 maximiliankolb