foreman-documentation icon indicating copy to clipboard operation
foreman-documentation copied to clipboard

Improvements to local serving

Open ekohl opened this issue 3 years ago • 7 comments

See individual commits for details, but the important part is that with this the cross document links are correctly linking to the local site rather than production.

ekohl avatar Apr 07 '22 13:04 ekohl

The PR preview for 706b18aa6a31a07c9d28b01f742465212d14c1e3 is available at theforeman-foreman-documentation-preview-pr-1204.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

github-actions[bot] avatar Aug 18 '22 11:08 github-actions[bot]

@evgeni does that mean you approve and it can be merged?

ekohl avatar Aug 23 '22 11:08 ekohl

I didn't test it, so can't really approve, but the concern I had is solved.

evgeni avatar Aug 23 '22 11:08 evgeni

I've rebased this and it works for me. Can we merge this before it gets out of date again?

ekohl avatar Aug 31 '23 16:08 ekohl

While testing this out I found it's annoying that it's not really live. Currently investigating nanoc with live serving.

ekohl avatar Aug 31 '23 16:08 ekohl

This now takes the approach of serving everything through nanoc, including the built guides. I'm still not quite happy with it, but pushing my work since it's a better direction.

ekohl avatar Aug 31 '23 17:08 ekohl

Rebased to resolve some conflicts, but no real change. https://github.com/theforeman/foreman-documentation/pull/2840 is related work that I want to build on.

ekohl avatar Feb 28 '24 12:02 ekohl