crates-io-api icon indicating copy to clipboard operation
crates-io-api copied to clipboard

Rewrite SyncClient to use AsyncClient internally

Open theduke opened this issue 5 years ago • 2 comments

To prevent code duplication, the SyncClient should be rewritten to just use the async client internally.

theduke avatar Apr 09 '19 11:04 theduke

This sounds good but do you mind if I do some PR fixing & adding some more functionality to the sync part first?

I'm close to releasing a crate I'm working on which has this project as a base dependency and I'd like to work on enabling the search filters, impl Default om some types (Sort, ListOptions), adding some more missing fields under Crate...

joseluis avatar Apr 11 '19 17:04 joseluis

Sure no problem, as long as you keep functionality in sync between sync and async versions.

theduke avatar Apr 11 '19 22:04 theduke