Christoph Herzog

Results 151 comments of Christoph Herzog

I'd rather rather remove `DroppableValue` and extend the types like `OwnedValue`(/Ref) (https://github.com/theduke/quickjs-rs/blob/master/src/bindings.rs#L475). I actually wanted to wrap all types coming out of quickjs immediately with custom types. I didn't do...

I'm all for it. For decimal, this might be a good fit: https://github.com/paupino/rust-decimal It's used by diesel for postgres I think. Are you interested in implementing this?

Happy to help if you run into any questions.

Ah yeah, > The binary representation consists of a 96 bit integer number, a scaling factor used to specify the decimal fraction and a 1 bit sign I thought `decimal`...

Module loading is not supported yet. I have some initial work on it, I should be able to get to it next week. It won't be enabled by default though...

Hey. Thanks for this effort, supporting MSVC is very valuable! > Also, if you are interested in merging this PR, please consider maintaining a separate QuickJS fork instead of using...

I'm looking into this again. It will require quite a few patches to the codebase though, sadly.

Good news! I managed to transpile Quickjs to Rust with `c2rust`, and I have the code running fine after some relatively sparse refactoring. I will need to patch out the...

Little progress update: I've done quite extensive cleanup of the `c2rust` generated code. I probably introduced some bugs during reafactoring of the types, but the basics all seem to work...

So, what's the best way to move this forward? A concrete proposal?