Anthony Dodd

Results 219 comments of Anthony Dodd

@OtaK also, I'm happy to implement the proposed channels based pattern. I just don't want to go vigilante and implement a bunch of changes which the maintainers don't want `:)`....

@OtaK so, using a `futures::sync::{mpsc, oneshot}` based approach may actually simplify things quite a bit, as no locking would be needed inside of the type which owns the connections and...

Either way, I'm definitely thinking that the [stream cancel](https://github.com/YellowInnovation/nitox/pull/26) & [streaming support](https://github.com/YellowInnovation/nitox/pull/15) PRs should land first. Maybe even a quick update to the code base overall to cut over to...

Anything I can help out with on this PR? I'm happy to write tests and such if that is what is needed.

... moved "todo" comment here to #21.

@OtaK just saw your response. It wasn't showing up earlier for some reason ... maybe I just needed to refresh `:)`. Cool, sounds great. I just forked so that I...

@OtaK sorry for spamming you so hard on this PR, but while I was doing some code review in this PR, I noticed that the streaming subscription (specifically in the...

@OtaK my changes are pretty much done in the PR I opened. Easiest way to review it would be to select only my commits, as there are commits from develop...

@o0Ignition0o thanks for the heads up. No rush.

Hey @christophermaier. If you need to immediately start using nitox streaming, you can update your Cargo.toml to depend on nitox from the repo in this PR: https://github.com/YellowInnovation/nitox/pull/21 - it is...