imgui-node-editor icon indicating copy to clipboard operation
imgui-node-editor copied to clipboard

Published 20 hours ago • verified publisher icon thedmd

Cannot minimise window.

Open Gh0stBlade opened this issue 5 years ago • 13 comments

If the Editor is inside a window or child window it cannot be minimised it simply messes up the entire rendering of ImGui. It looks to be framebuffer related.

Examples:

  1. Before minimise. image

  2. After minimise. image

You should notice that in the above image the main ui render target is off centered and not properly rendered. In some cases it looks way worse than this.

  1. After relaunching the application and launching the Editor. It simply renders nothing. image

Gh0stBlade avatar Sep 20 '20 15:09 Gh0stBlade

Can you tell if editor is updated when it's window is minimized?

thedmd avatar Sep 20 '20 22:09 thedmd

Looks like all the code is executed when the window is minimised.

Gh0stBlade avatar Sep 21 '20 13:09 Gh0stBlade

Does it help if you skip calling the editor when window is minimized?

thedmd avatar Sep 21 '20 20:09 thedmd

If i skip everything between ed::begin and ed::end there are no issues.

Gh0stBlade avatar Sep 21 '20 22:09 Gh0stBlade

I will guard the code for that case.

thedmd avatar Dec 04 '20 09:12 thedmd

@Gh0stBlade Issue is fixed on develop branch. I'm punching out there fixes for other issues before making a release. So it is as stable as it can get.

thedmd avatar Dec 05 '20 16:12 thedmd

Not fixed at all in develop, I have exactly the same issues but worse.

Gh0stBlade avatar Dec 06 '20 13:12 Gh0stBlade

Thanks for an update. I suspect this may be related to mouse being moved to (-1, -1) when focus is lost. Can you confirm this?

thedmd avatar Dec 07 '20 08:12 thedmd

There was a fix for dragging shooting to infinity when window loose focus. Can you it? It is on develop.

Can you tell me what size is sent to ed::Begin() when window is minimized?

Can you reproduce this bug with on of the examples?

thedmd avatar Dec 25 '20 13:12 thedmd

I can confirm this is still not fixed, will investigate further. It might be a rendertarget issue.

Gh0stBlade avatar May 30 '21 15:05 Gh0stBlade

@Gh0stBlade Hello, did you found a bug maybe?

thedmd avatar Jul 08 '21 03:07 thedmd

It seems like it's writing to an invalid rendertarget when I do the bug steps to reproduce this. I checked this in renderdoc. My editor is using deferred rendering, no idea why this is happening.

Gh0stBlade avatar Jul 09 '21 11:07 Gh0stBlade

Editor does not have control over that. Always use current ImGui context and current window. Is this by chance an issue of not setting correct context (editors orx imgui)?

thedmd avatar Jul 09 '21 17:07 thedmd