voyager icon indicating copy to clipboard operation
voyager copied to clipboard

Get model relationships after and with translation

Open almooradi-dev opened this issue 2 years ago • 1 comments

We had a problem, that we weren't getting the model relations after translating the main model. For example: $posts = Post::with(['author', 'translations'])->get()->translate('locale', 'fallbackLocale'); The problem is that the author parameter (relation) is not appearing in the final translated object, just the main attributes.

And we have fixed this problem.

almooradi-dev avatar Feb 21 '22 17:02 almooradi-dev

Please check this also #5554

YoussefMaged avatar Apr 11 '22 22:04 YoussefMaged

Why are these changes not merged

a-ahmed116 avatar Dec 21 '22 10:12 a-ahmed116

I approved the review why it not merged ?

AlaaL avatar Dec 21 '22 11:12 AlaaL

First, I'm glad that this was a part to solve your problem.

Second, does the merging problem have something to do with me (as I have the first commit) or is it something related to the "Voyager" authors?

almooradi-dev avatar Dec 22 '22 06:12 almooradi-dev

First, I'm glad that this was a part to solve your problem.

Second, does the merging problem have something to do with me (as I have the first commit) or is it something related to the "Voyager" authors?

I think the Voyager authors not doing any merges, there are a lot of pull-requests not merged, I fell like the project is dead

AlaaL avatar Dec 22 '22 10:12 AlaaL