safe icon indicating copy to clipboard operation
safe copied to clipboard

Are you looking for maintainers here?

Open OskarStark opened this issue 1 year ago • 1 comments

It looks like there is not much activity here, so I would offer my help to maintain this repository.

Cheers, Oskar

cc @mvhirsch @igst @silasjoisten @localheinz @staabm

OskarStark avatar Sep 11 '24 14:09 OskarStark

I would too.

silasjoisten avatar Sep 29 '24 10:09 silasjoisten

FWIW I have a maintained fork (with nearly all of the PR's here merged, flagged as a drop-in replacement so you only need to update dependencies for the top-level composer.json) at https://github.com/shish/safe

shish avatar Nov 21 '24 12:11 shish

Hey all!

Sorry, @Kharhamel and I have had some hectic schedule. I'm working full time on WorkAdventure and obviously don't have enough time to maintain the project appropriately.

So, YES! we are looking for maintainers.

I'll do my best to put Safe in a correct state for PHP 8.4, but Safe definitely needs some love. @shish I'll probably backport the changes in your fork. Do you want to be added as a maintainer? (@OskarStark, @silasjoisten I would be happy to add you too, shall I do that?)

moufmouf avatar Nov 25 '24 18:11 moufmouf

Yes please add both of us (Silas and I are working together)

OskarStark avatar Nov 25 '24 20:11 OskarStark

@OskarStark @silasjoisten Done! What would be the good way of doing things starting from here? Backporting all @shish changes and then starting merging submitted PRs that are not already part of @shish work?

moufmouf avatar Nov 25 '24 21:11 moufmouf

Sounds good to me!

silasjoisten avatar Nov 25 '24 21:11 silasjoisten

Yeah I'm happy to be added as a maintainer and avoid fragmentation :)

shish avatar Nov 26 '24 05:11 shish

@staabm, what about you?

OskarStark avatar Nov 26 '24 06:11 OskarStark

sure, why not.

(Please also add us to the phpstan extension repo)

staabm avatar Nov 26 '24 07:11 staabm

Cool! @shish @staabm @OskarStark @silasjoisten You have all be added to this repo and the PHPStan extension.

Super happy to have you guys as maintainers. I should have done that way before!

I think the best thing to do for me is to step aside and let you guys merge your respective PRs and tag releases accordingly. You are all experienced maintainers so I won't get in the way! :heart:

moufmouf avatar Nov 26 '24 13:11 moufmouf

Thanks for the trust and being open 🖖 community will thank you 🙏

OskarStark avatar Nov 26 '24 14:11 OskarStark

When you backport the changes, I'd appreciate if you please don't drop support for PHP 8.1 until it's officially EOL next year 😄

https://github.com/thecodingmachine/safe/pull/441#issuecomment-2499226690

danepowell avatar Nov 26 '24 19:11 danepowell