gotenberg-go-client icon indicating copy to clipboard operation
gotenberg-go-client copied to clipboard

error return adjustment for client

Open tbal999 opened this issue 3 years ago • 2 comments

sometimes you get:

failed to generate the result PDF in func (c *Client) StoreContext(ctx context.Context, req Request, dest string) error

when you shouldn't. I.E when the server is still processing a file.

so I did the below in a fork

https://github.com/tbal999/gotenberg-go-client/blob/48b3dc83b02f25f223a06bed4dc8cd51a2c18f60/client.go#L140

and it fixed the issue by returning an error & status if the status is an error.

could you please consider this PR.

thanks

tbal999 avatar Feb 01 '22 11:02 tbal999

Hello @tbal999,

I alas don't have time to maintain this client, so no ETA for a review / merge / release..

gulien avatar Feb 02 '22 13:02 gulien

no worries/rush gulien - just forked it & it's working fine for my use case.

tbal999 avatar Feb 02 '22 14:02 tbal999