docker-images-php icon indicating copy to clipboard operation
docker-images-php copied to clipboard

make apache ports configurable

Open mms-gianni opened this issue 1 year ago • 3 comments

Summary

This PR fixes/implements :

  • [ ] Bug
  • [X] Feature
  • [ ] Breaking changes

Explain the motivation for making this change. What existing problem does the pull request solve?

Adds the possibility to run the apache on a different port than 80 and 443. See issue https://github.com/thecodingmachine/docker-images-php/issues/360

Test plan (required)

The ports will be configured on startup by entrypoint. Need some help here to test it.

Checklist

  • [X] I followed the guidelines in CONTRIBUTING guide
  • [X] I have squashed any insignificant commits
  • [X] This change has comments for package types, values, functions, and non-obvious lines of code

mms-gianni avatar Mar 17 '23 10:03 mms-gianni

I can squash the commits if prefered.

mms-gianni avatar Apr 10 '23 19:04 mms-gianni

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please update it if any action still required.

stale[bot] avatar Jun 09 '23 23:06 stale[bot]

This issue has been automatically closed because it has not had recent activity. Please, reopen if you need.

stale[bot] avatar Jun 17 '23 01:06 stale[bot]