changelog.com icon indicating copy to clipboard operation
changelog.com copied to clipboard

newsletter links-proxy encodes special urls with html instead of percent-based

Open dym-sh opened this issue 2 years ago • 4 comments

example (of https://changelog.com/news/its-all-gravy-53Pa )

https://email.changelog.com/t/t-i-cddnly-qduttcki-nd/

  • current: => https://chris.manson.ie/it's-all-gravy
  • supposed: => https://chris.manson.ie/it%27s-all-gravy/

dym-sh avatar Nov 07 '21 13:11 dym-sh

Thanks for the report! This has something to do with how Phoenix.HTML.Link.link/2processes our news item links when we send them to it in our news issue templates:

https://github.com/thechangelog/changelog.com/blob/fb661d0cf3a4db731d46ef7f1cec44a5d1f4581a/lib/changelog_web/templates/news_issue/_item.html.eex#L6

Not sure what/if anything we can do about it as a user of that API, but happy to learn!

jerodsanto avatar Nov 08 '21 21:11 jerodsanto

make different pipeline for email links :shrug:?

ghost avatar Nov 08 '21 21:11 ghost

Is this still relevant @jerodsanto?

gerhard avatar Aug 23 '22 23:08 gerhard

It's still a bug that hasn't been fixed, if that's what you mean by relevant?

jerodsanto avatar Aug 30 '22 18:08 jerodsanto

This one is no longer relevant because we aren't proxying newsletter links anymore. Direct links FTW!

jerodsanto avatar Apr 19 '23 20:04 jerodsanto