changelog.com icon indicating copy to clipboard operation
changelog.com copied to clipboard

Published 20 hours ago • verified publisher icon thechangelog

Feat/feed specific topics

Open hailelagi opened this issue 3 years ago • 6 comments

addresses: https://github.com/thechangelog/changelog.com/issues/384

hailelagi avatar Sep 29 '21 20:09 hailelagi

I think the existing FeedController is a better place for this functionality, since there is nothing new/unique about a topic feed. It's just another feed with different/specific content.

jerodsanto avatar Oct 11 '21 15:10 jerodsanto

Yeah, I agree that makes more sense. My initial thinking was to decouple the functionality so the controller could be smaller and avoid namespace issues but taking another look now this leads to a lot more unnecessary boilerplate.

hailelagi avatar Oct 12 '21 02:10 hailelagi

Hi @jerodsanto I kind of dropped off on this last year sorry about that, but I really want to pick it back, although it's been quite awhile! If this is something useful I'll try to dive back in! cheers

hailelagi avatar Jun 15 '22 10:06 hailelagi

Yeah man, let's pick it back up!

jerodsanto avatar Jun 21 '22 15:06 jerodsanto

There are a few failing tests: https://app.circleci.com/pipelines/github/thechangelog/changelog.com/812/workflows/db6d709a-3d33-49e4-9e22-b027d7fe1712/jobs/5532?invite=true#step-105-1171

When they get fixed, what needs to happen before this can get merged @jerodsanto?

gerhard avatar Aug 23 '22 23:08 gerhard

I have a few changes on my local host, I think I can close this out this weekend, but happy to take any pointers on direction

hailelagi avatar Aug 24 '22 08:08 hailelagi

Alright @hailelagi @gerhard I've got a PR ready for reviews: https://github.com/thechangelog/changelog.com/pull/430 (I branched off of this PR branch)

Nezteb avatar Oct 02 '22 05:10 Nezteb