corneal icon indicating copy to clipboard operation
corneal copied to clipboard

Update to ActiveRecord 5 for higher ruby version compat

Open morgvanny opened this issue 4 years ago • 5 comments

ActiveRecord 4 no longer works with Ruby 2.7.1, but version 6 seems to not work properly with Sinatra and migrations won't run with it, so version 5 seems like a happy medium to stick with for a while.

morgvanny avatar Jul 30 '20 09:07 morgvanny

by using gem 'bigdecimal', '1.3.5' we can have 6! but i dont know what we would lose. tests needed.

adisciple50 avatar Oct 07 '20 17:10 adisciple50

put gem 'bigdecimal', '1.3.5' in the boilerplate Gemfile.

adisciple50 avatar Oct 07 '20 17:10 adisciple50

it works, but i have not tested this!

the early bigdecimal does not warn of bigdecimal().new. i found this on some arcane forum tomb of a page.

adisciple50 avatar Oct 08 '20 12:10 adisciple50

Ah yeah I got version 6 working at some point after this, and never came back to it

morgvanny avatar Oct 10 '20 03:10 morgvanny

I tested this PR, it is working as expected. thank you!

JuanVqz avatar Feb 24 '21 01:02 JuanVqz