pydeps icon indicating copy to clipboard operation
pydeps copied to clipboard
verified publisher icon thebjorn

Underscores stripped from clustered package names

Open mortlind opened this issue 4 years ago • 2 comments

Is there any particular reason why the line of code referenced below strips underscores from clustered package names? It makes the nodes harder to read for me.

https://github.com/thebjorn/pydeps/blob/2c0b958b2f4dd6e00f59b37e63c218d53e6e1773/pydeps/render_context.py#L295

mortlind avatar Nov 09 '21 21:11 mortlind

Ah, an especially well-documented function :-D

If I remember correctly, it is to satisfy the naming constraints on subgraph in graphviz (https://github.com/thebjorn/pydeps/blame/2c0b958b2f4dd6e00f59b37e63c218d53e6e1773/pydeps/render_context.py#L237), but it is probably a bug that the next line uses the cluster id for the label text...

thebjorn avatar Nov 10 '21 17:11 thebjorn

Simply commenting out the .replace('_', '')-part of the line solved the problem for me. There seemed to be no problem with cluster-ID constraints. Maybe something changed in Graphviz?

mortlind avatar Nov 10 '21 21:11 mortlind

Any progress on this one ? Any chance this gets fixed in some future release ?

dd-ssc avatar May 13 '23 09:05 dd-ssc

Check out v1.12.4 available on PyPI.

thebjorn avatar May 13 '23 22:05 thebjorn