Adam Hines

Results 25 comments of Adam Hines

Let me know if there is anything left to address here after the ecosystem run. I'm still eager to get this change merged.

I have experienced this problem as well and I have narrowed this down in my codebase to the tsconfig.json not including "src/**/*.vue". If I explicitly include all the .vue files...

> IMO This is expected, you should include `*.vue` files if you want them to get type-checked. I see where you are coming from, but if those .vue files are...

I'm curious if this PR addresses your the issues mentioned here: https://github.com/vitejs/vite/pull/14467 I filed it over a year ago and there are some conflicts that need to be resolved, but...

I'll see if I can create a small reproducer.

I created a test repo that demonstrates 3 separate failures across yarn, pnpm and npm that are related to the issue in this PR. I was really hoping to just...

@sheremet-va assuming this change looks good for the vitest 3.x release, is there any chance of back-patching it to 2.1.9 while waiting for the official 3.x release?

The 2.1.7 [release notes](https://github.com/vitest-dev/vitest/releases/tag/v2.1.7) implied a soft support: > We will enable support for it later. In the meantime, you can still use pnpm.overrides or yarn resolutions to override the...

@sheremet-va would it be possible to get this looked at again for a future vitest 3 alpha release?

@hi-ogawa / @sheremet-va Thanks for your help with the revisions. I was able to add a test case for this which fails in vite 6 without this change, but succeeds...