MMRA icon indicating copy to clipboard operation
MMRA copied to clipboard

Fix "pardon the interruption" popup block

Open thebaer opened this issue 5 years ago • 4 comments

We must no longer "pardon the interruption" -- now we can "extend our stay" and so on. The <h1> text in this popup changed, and there seems to be a few titles that get displayed. So now we look to the <h2> instead for blocking the readus interruptus popup.

This fixes #51.

thebaer avatar Jun 07 '19 12:06 thebaer

Seems to target it correctly, however at least on https://medium.com/mergify/automatic-merge-of-github-security-fixes-87d7781140c0 I see basically the animation still before it vanishes. But that doesn't seem to happen for all articles, somehow. It feels it has to do with how fast the page loads, so the basically the images there delaying the load somewhat.

jhass avatar Jun 07 '19 13:06 jhass

Yeah, I'm not sure how to get rid of the animation unfortunately. But this at least hides it for now

thebaer avatar Jul 23 '19 18:07 thebaer

Do you plan on merging/releasing this any time soon?

a1russell avatar Oct 14 '19 14:10 a1russell

These changes don't completely fix the issue anymore -- Medium is still making all kinds of changes that invalidate work here.

thebaer avatar Oct 14 '19 15:10 thebaer