django-nested-admin icon indicating copy to clipboard operation
django-nested-admin copied to clipboard

Inlines weird behavior with django-grappelli integration

Open HaddadJoe opened this issue 2 years ago • 0 comments

I'm running into some weird behavior when trying to run/integrate a multiple layer nested admin with grappelli.

Here's the original issue opened on django-grappelli

here's the dummy models I have. Nothing too fancy, pretty straightforward nested models. Note that the Article has two foreign key referencing it. One from the image and one from the paragraph models.

class TableOfContents(models.Model):
    title_tableofcontents = models.TextField()


class TocSection(models.Model):
    title_tocsection = models.TextField()
    table_of_content = models.ForeignKey(TableOfContents, on_delete=models.CASCADE)


class TocArticle(models.Model):
    title_tocarticle = models.TextField()
    section = models.ForeignKey(TocSection, on_delete=models.CASCADE)


class TocParagraph(models.Model):
    title_tocparagraph = models.TextField()
    article = models.ForeignKey(TocArticle, on_delete=models.CASCADE)


class TocImage(models.Model):
    title_tocimage = models.TextField()
    article = models.ForeignKey(TocArticle, on_delete=models.CASCADE)

Here's how my admin looks without trying to rearrange the nested inlines. Also nothing too fancy here pretty straightforward, just note that article is already an inline of sections (which is an inline of table of content)

class TocParagraphInline(NestedStackedInline):
    model = models.TocParagraph


class TocImageInline(NestedStackedInline):
    model = models.TocImage


class TocArticleInline(NestedStackedInline):
    model = models.TocArticle
    inlines = [TocParagraphInline, TocImageInline]
    fieldsets = [
        (
            "Image Data",
            {
                "fields": [],
                # "classes": [
                #     "placeholder tocsection_set-1-tocarticle_set-0-tocimage_set-group"
                # ],
            },
        ),
        (
            "Paragraph Data",
            {
                "fields": [],
                # "classes": [
                #     "placeholder tocsection_set-1-tocarticle_set-0-tocparagraph_set-group"
                # ],
            },
        ),
        (
            "Article Data",
            {"fields": ["title_tocarticle"]},
        ),
    ]


class TocSectionInline(NestedStackedInline):
    model = models.TocSection
    inlines = [TocArticleInline]


class TableOfContentsAdmin(NestedModelAdmin):
    inlines = [TocSectionInline]


admin.site.register(models.TableOfContents, TableOfContentsAdmin)

Here's how things look on the admin UI image

Now as you might have guessed, my goal is to rearrange the inlines image and paragraph under the designated fieldsets for each category. When uncommentting the classes to try to rearrange them some weird behavior happen. here's a screenshot image

As you can see the sections have been rearranged correctly but as a consequence:

  1. The title of the fieldset, here Image Data and Paragraph Data have disappeared.
  2. The blue tabs to un-collapse the inlines does not work on preloaded inlines 2.1 If I add a new article the un-collapsing works but the title of the fieldset mentioned in 1) is not present either.
  3. The add Image and Paragraph buttons also stop working when the inlines are moved.

I see that django-nested-admin has good intention in supporting grappelli. Would appreciate any help or directions, happy to contribute if I can help!

django = "4.1.5" django-nested-admin = "4.0.2"

HaddadJoe avatar Jan 09 '23 10:01 HaddadJoe