spicetify-hide-podcasts icon indicating copy to clipboard operation
spicetify-hide-podcasts copied to clipboard

Podcast related items sometimes load in after page load

Open lazyb5 opened this issue 3 years ago • 22 comments

Using 1.1.61.583.gad060c66-a

Podcast related items show on top of my main screen. They will hide with a toggle of "hide podcasts" button. But then new ones show again.

lazyb5 avatar Jun 09 '21 22:06 lazyb5

It still seems to work fine for me on 1.1.61.583.gad060c66-a on macOS. What items are showing up? Are you able to post a screenshot? Also, can you outline the steps to reproduce a little better? You have the extension enabled (podcasts disabled) before you start Spotify, then you launch it and they show up. And if you turn off the extension and turn it back on, they disappear. And which new ones show again, when?

theRealPadster avatar Jun 10 '21 01:06 theRealPadster

pcast

It will then disappear when I toggle hide podcasts on and off. Nothing is showing now, but I will capture video of it next time something shows up. I have hide podcast turned on when Spotify is started. I'll see if they show up with Spotify just running or show up on restart.

lazyb5 avatar Jun 10 '21 23:06 lazyb5

https://user-images.githubusercontent.com/23584680/121634415-81476180-ca52-11eb-9f66-0613c876e1be.mp4

Showed up after spotify was running idle.

lazyb5 avatar Jun 11 '21 05:06 lazyb5

Thanks for the screen+video. When you start Spotify with the extension enabled, does it show podcasts right away, or just after using the app for a while? Are you staying on the home screen or navigation around the app? I have pushed an update (8f4ca3d) that should help if podcasts are showing up on initial app load; can you give that a try and see if it makes any difference?

theRealPadster avatar Jun 11 '21 21:06 theRealPadster

I will update this post with more data as I see ads. One popped UP after app was just idle for about 15 hours. I was navigating into the home page from another playlist.

Showed up from a computer shut down. Cold open of spotify.

lazyb5 avatar Jun 13 '21 11:06 lazyb5

image

Had computer sitting idle. Stayed on the front page of Spotify. Appeared During the idle.

lazyb5 avatar Jun 18 '21 13:06 lazyb5

I tried leaving it open overnight on the homepage and it still didn't have any podcast items appear. I'm not sure how I'd test or fix it. Right now it listens and scans on app history/path name changes. If you open up the dev console, does it show anything like this after it shows podcast stuff? image

theRealPadster avatar Jun 19 '21 18:06 theRealPadster

I added a "debug" branch that has a little more logging enabled. Could you switch to that in case it helps me figure out what's going on? If the content of the page is refreshing somehow without actually triggering a pathname change, I'm not sure there's much I can do. I don't want to leave MutationObserver that waits for the page to be ready running all the time, as it would kill performance and trigger it to re-run way too often.

theRealPadster avatar Jun 19 '21 18:06 theRealPadster

I don't know how to get to dev console, I'm a n00b. I have installed the dev branch. Likewise, I also don't know how to get the log you're looking for with that.

lazyb5 avatar Jun 19 '21 19:06 lazyb5

Run spicetify enable-devtool and then it should have a "develop" section in the Spotify menu. Open the web inspector/console in that menu. It should open a window with a bunch of logs at the bottom. I think that's all you need to do to set it up, but I'm on my phone, so lmk if that doesn't do it.

theRealPadster avatar Jun 19 '21 21:06 theRealPadster

So a podcast carousel did show up at idle. There wasn't much in the log, don't know if I'm not looking in the right place. THE End is the entry of me clicking hide podcasts two times to restart it. Seems like it just not reacting at all. Are there other issues at play with my spictify install? image

lazyb5 avatar Jun 20 '21 11:06 lazyb5

It just happened to me as well. I just open the app and was playing music from the homepage. The logs don't show any load events or anything either, so it must be refreshing the content without doing any navigation. I'll have to see if it's possible to catch when that happens without tanking performance... :/ image

theRealPadster avatar Jun 21 '21 17:06 theRealPadster

Just adding a note here so I don't forget - khanhas suggested

You can always use MutatationObserver and setTimeout to wait till app is "fully" loaded.

This is an alternative to the method of waiting for content, but it's debatable if it's any better than specifically hardcoding which item to wait for if the main item doesn't work (e.g. Search page).

It doesn't look like there's a good way to tell if new content has loaded in. I can maybe experiment with leaving the MutationObserver running, but we may just have to live with it :/

theRealPadster avatar Jun 23 '21 21:06 theRealPadster

@lazyb5 It does look like you could potentially use the "home config" feature from Spicetify v2.3.0 and "lower" any podcast carousels as a workaround

theRealPadster avatar Jun 23 '21 21:06 theRealPadster

Wasn't sure if I should open a new ticket or add to this one, but up until about 2 weeks ago it was working fine for me, (Windows 10), but now none of the advanced options are showing.

mix3d avatar Nov 16 '21 15:11 mix3d

@mix3d what are the "advanced options"? This extension just has enabled or disabled.

theRealPadster avatar Nov 16 '21 15:11 theRealPadster

@theRealPadster image The setting to turn on/off

Here's my config: image

This extension was literally what I downloaded spicetify for XD

mix3d avatar Nov 16 '21 16:11 mix3d

Ah, this might help: image

mix3d avatar Nov 16 '21 16:11 mix3d

the classnames seem to be obfuscated now: image

mix3d avatar Nov 16 '21 16:11 mix3d

Aha! I thought I had updated my spicetify with spicetify update, but the correct command was spicetify upgrade. Moving from v2.7.1 to v2.8.1 fixed my issues. Hooray! (And sorry for the trouble)

mix3d avatar Nov 16 '21 16:11 mix3d

@lazyb5 I just added an "aggressive mode" option that you can enable. Could you update to 2.4.0 and see if it helps?

theRealPadster avatar Jul 29 '22 22:07 theRealPadster

@theRealPadster OK, I have it enabled. Some podcasts have been showing up, but not a lot. I'll let you know if any show up in this mode.

lazyb5 avatar Jul 30 '22 03:07 lazyb5

Closing as resolved for now. Feel free to re-open if the issue persists.

theRealPadster avatar Sep 06 '22 01:09 theRealPadster