Fast-F1
Fast-F1 copied to clipboard
theOehrly
remove D_LOOKUP table
This hard-coded table is out of date and doesn't seem to be used anywhere.
Technically this is public API even though it's not in the documentation. I think we could probably skip a proper deprecation here. Do you know if or how this was last used anywhere?
I can find two places in the git history where this table was used.
The table was first added in this commit back in February 2020 for compatibility with 2020 winter tests. The original use case was removed in this commit in July 2020 but a new dependency was added. That dependency was removed here in March 2022. This is the last time I can find D_LOOKUP in any diff.
The second use case is added here in November 2020 to reimplement driver ahead calculation. The usage is fairly trivial. This dependency is removed less than a month later in this commit.
So this table was never used extensively anywhere. And we have not needed it for the last two years.
Ran pylint to find if we have other unused variables like that but seems like we are pretty good about that issue. I just looked over the output and fixed a few minor things.
OK, thanks for the investigation. Given that it was only ever used internally, never documented and is long out of date and therefore basically useless, I'll say it's fine to skip a proper deprecation here.