react-remove-scroll icon indicating copy to clipboard operation
react-remove-scroll copied to clipboard

Not working in iframe

Open seleckis opened this issue 1 year ago • 4 comments

Here is an example when RemoveScroll is used inside React Frame Component. The main body is locked but iframe is not. Codesandbox

seleckis avatar Aug 16 '24 10:08 seleckis

Thank you for a perfect example, I know what to do next

theKashey avatar Aug 16 '24 10:08 theKashey

update: that would take a while to update all required pieces. In short: react-remove-scroll should share "current document" (or just element) to react-remove-scroll-bar, which in turn should configure react-style-singleton to inject styles in the right place. Right now these styles are always injected to the document of a "script", and in case operation is performed in another iframe it ends non locked.

While the change is simple, it has to be done in many places and require API update.

theKashey avatar Aug 17 '24 08:08 theKashey

Wow, that fragmentation is unexpected :)

seleckis avatar Aug 19 '24 06:08 seleckis

This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far.

stale[bot] avatar Oct 19 '24 01:10 stale[bot]

Still not forking in iframe

olivierpascal avatar Feb 17 '25 10:02 olivierpascal

This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far.

stale[bot] avatar Apr 23 '25 03:04 stale[bot]