proxyequal icon indicating copy to clipboard operation
proxyequal copied to clipboard

Performance Improvements

Open ScriptedAlchemy opened this issue 6 years ago • 4 comments

Hey Anton,

I've been looking over the code and spotted a few areas where we might be able to improve performance.

There's some small ideas I had based on chip architecture that should speed up loops (looping backwards is faster than forwards), as well as my understanding of how native methods have been implemented into the browser & what their performance is capable of (filter is slow)

Mind if I open a PR? Also, do you know if any specific areas where bottlenecks are occurring?

Would love to boost the benchmarks if possible :)

ScriptedAlchemy avatar Mar 28 '19 05:03 ScriptedAlchemy

Hi @ScriptedAlchemy @theKashey Wouldn't it better to prepare a benchmark suite within this project? It should speed up the try-evaluate cycle and it'd be more comprehensive.

dai-shi avatar Mar 28 '19 08:03 dai-shi

That's a good idea. I had some benchmarks on memoize-state, the library this library was built for, but not here.

theKashey avatar Mar 28 '19 09:03 theKashey

I can look at creating some benchmark. What tools to you typically use for such things?

ScriptedAlchemy avatar Mar 28 '19 15:03 ScriptedAlchemy

🤔🤷‍♂️, js-perf

theKashey avatar Mar 28 '19 21:03 theKashey