Stephan Seitz

Results 487 comments of Stephan Seitz
trafficstars

I think this should be ready. Just two often questions: - Should token resolve start/end byte like in the out-commented text or just `offset_encoding` (-> update the docs after decision)...

> > With the bytes resolved, emojis don't cause any shifts in the highlighting any more > That's the correct behavior right? yes > I would move the file under...

Tests are failing due to a slightly wrong implementation for the non-`bit` path (round-off errors)? Apparently, they are supported as real operators in Lua 5.3 https://www.lua.org/manual/5.3/manual.html#3.4.2 ? EDIT: fixed by...

Yes, we should use `ts_parser_set_timeout_micros(*p, );` in `parser_parse`. We need to think of something that we should do when the timeout is reached. We would still have the old parsed...

Please look at the diff of this PR: https://github.com/neovim/neovim/pull/18761 `ts_parser_set_timeout_micros` is out-commented. All code doing `parser_parse` must be adapted to react to a timeout (timeout could return `nil` or Lua...

Yes, this needs to be resolved in neovim core. We often solve issues reported here in Neovim core.

TODO myself: write the answers in long prosa. > It seems that the scripts/run_tests.sh system doesn't use the highlighting files in the repo but that are installed with :TSInstall, making...

I've opened two PRs. Can you tell which one you like better? I guess using the HTML parser for XML should be fine (#3297). The XML parser in #3296 had...

@asmodeus812 but the HTML parser works better (it seems to be the HTML forked a long time ago) and is maintained (though XML should not change). I'd recommend to test...

@asmodeus812 just write a query for that recognizes the start tag as `@start` and the end tag as `@end`. You should then be able to either jump between start tags...