tvb-root icon indicating copy to clipboard operation
tvb-root copied to clipboard

Published 20 hours ago • verified publisher icon the-virtual-brain

Rateml ebrains fix

Open DeLaVlag opened this issue 3 years ago • 13 comments
trafficstars

small fix for rateml usage on ebrains for args parser and additionally the hpc version of the zerlaut model

DeLaVlag avatar May 16 '22 14:05 DeLaVlag

Hi, which bug needs to be fixed here?

DeLaVlag avatar Jun 02 '22 12:06 DeLaVlag

There's a merge conflict, maybe that's what's meant by the bug label.

maedoc avatar Jun 02 '22 13:06 maedoc

I don't see that much confliction. Is there something I need to fix?

DeLaVlag avatar Jun 02 '22 14:06 DeLaVlag

Yes, you have to resolve the conflict or the branch can't be merged. If the conflict is simple, then you are lucky.

maedoc avatar Jun 02 '22 14:06 maedoc

Hi, which bug needs to be fixed here?

Hi. The tag bug on this PR was added because I understand this code fixes a problem/bug in the previous versions, not for being buggy this PR itself.

But a merge from here was indeed problematic, as things changed in master since this PR was opened. Mainly we renamed scientific_library folder into tvb_library. Usually a simple rebase with master in existing older PRs should solve conflicts, except when new files were added in the old folder, then those files need to be moved to the new location in a new commit. I just did these steps here, and the PR should be in good technical state (hopefully all tests pass). Remains up to @maedoc to judge the logic of these changes in detail.

liadomide avatar Jun 02 '22 20:06 liadomide

Is there any demo of using the Zerlaut model? A notebook or similar? It's a lot of code to add without any tests etc.

maedoc avatar Jun 03 '22 07:06 maedoc

The demo is in progress. I want to set this up for the CNS satellite workshop. The fix for the XML2model is necessary for running it in the collab. I could add the model to the tests we have for rateml.

DeLaVlag avatar Jun 03 '22 13:06 DeLaVlag

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 115 Code Smells

0.0% 0.0% Coverage
42.3% 42.3% Duplication

sonarqubecloud[bot] avatar Jun 03 '22 13:06 sonarqubecloud[bot]

A generic notebook demo how to run the Zerlaut on HPC through pyunicore is added. Also the Zerlaut model has been added to the tests.

DeLaVlag avatar Jul 01 '22 13:07 DeLaVlag

Can you have a look at the test failures ("lib-tests" check) please?

maedoc avatar Jul 04 '22 09:07 maedoc

Still in progress... I tried to fix the tests but now I get lots of errors related to the runner. Also the lib tests didn't get picked up.

DeLaVlag avatar Sep 27 '22 08:09 DeLaVlag

The lib runner has a network problem, I'm working on it. You could ignore it for the moment.

maedoc avatar Sep 27 '22 11:09 maedoc

@DeLaVlag there's a test which isn't passing, can you take a look? does it pass on your system?

maedoc avatar Oct 18 '22 12:10 maedoc

sorry for the force push, but it dropped all the deleted files from teh bct which is a git fart not related to this pr.

maedoc avatar Dec 05 '22 22:12 maedoc