Add BOLD CUDA driver for RateML

[DeLaVlag]

trafficstars

@maedoc here an example of the model and bold cuda driver.

[maedoc]

I fixed the issue with the full_tests but code analysis still fails because there's no test coverage for the bold driver; I guess it should run during the tests.

@liadomide two Qs

• what is merge policy on failing code analysis?
• is it ok to start the list of grants in the ACKNOWLEDGEMENTS.md file here or we should collect more widely first?

[liadomide]

Hi M.

@liadomide two Qs

• what is merge policy on failing code analysis?

We are still adjusting the Sonar gates, and we have plenty of legacy issues. Thus, for now, it is your choice if you take the Sonar failure as blocker, or you ignore it. Mid term (hopefully this autumn) we should have a more strict and clear policy in place. Feedback on this is welcome.

• is it ok to start the list of grants in the ACKNOWLEDGEMENTS.md file here or we should collect more widely first?

We started a chapter Ackn at the end of the top README file in the repo: https://github.com/the-virtual-brain/tvb-root#acknowledgments This is something that we found in other EBRAINS modules done and given as best practice, but if you have an argument for the separate ACKNOWLEDGEMENTS.md, I have no strong objection to change. I would like though to have a unified manner in which all of us add Ack.

[DeLaVlag]

Then lets merge it in the acknowledgement section. There no need for a separate file.

Michiel.

On Fri, Mar 18, 2022, 14:23 Lia Domide @.***> wrote:

Hi M.

@liadomide https://github.com/liadomide two Qs

• what is merge policy on failing code analysis?

We are still adjusting the Sonar gates, and we have plenty of legacy issues. Thus, for now, it is your choice if you take the Sonar failure as blocker, or you ignore it. Mid term (hopefully this autumn) we should have a more strict and clear policy in place. Feedback on this is welcome.

• is it ok to start the list of grants in the ACKNOWLEDGEMENTS.md file here or we should collect more widely first?

We started a chapter Ackn at the end of the top README file in the repo: https://github.com/the-virtual-brain/tvb-root#acknowledgments This is something that we found in other EBRAINS modules done and given as best practice, but if you have an argument for the separate ACKNOWLEDGEMENTS.md, I have no strong objection to change. I would like though to have a unified manner in which all of us add Ack.

— Reply to this email directly, view it on GitHub https://github.com/the-virtual-brain/tvb-root/pull/532#issuecomment-1072405981, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRBTCLH7RNN2EDJEDUAJGDVAR7TZANCNFSM5QYNFETA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

[sonarqubecloud[bot]]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
15 Code Smells

0.0% Coverage
60.1% Duplication

[liadomide]

Sorry for messing up your history! I intended to drop the duplicate acknowledgements (as agreed above). Then, I had the not so well inspired idea to do a rebase on your branch against master. While that is ok in general, to put all your commits together, it provoked some unwanted merge conflicts. I trust the final state is good, just the history suffered a little.

As a side note: coverage entirely, while available, is not yet correctly processed by Sonar. We will be working to have that fixed soon.

[maedoc]

I didn't have time to review this yet.

[maedoc]

Idem, ignore lack of lib testing for the moment, I'm working on it. hopefully then can review in near future.

[maedoc]

I reduced a bit the differences between the standard and bold drivers here, and I think the bold driver could just subclass the standard one.

[maedoc]

it seems like the heun file could be completely removed?

[maedoc]

as in the other PR just merged, the workflow approach needs improving, otherwise we can merge this.