pywerview icon indicating copy to clipboard operation
pywerview copied to clipboard

Use the same capitalization for actions as PowerView functions

Open asolino opened this issue 8 years ago • 3 comments

This is not a functional issue, but just an opinion.. and of course it's up to @the-useless-one to decide. I would however, use the same capitalization as PowerView's functions. For example:

  1. invoke-checklocaladminaccess to Invoke-CheckLocalAdminAccess
  2. get-netgroupmember to Get-NetGroupMember and so on.

I would do the same for the specific parameters for each function.

Why?.. Besides looking prettier (personal opinion ;) ), it will help PowerView users to transition easier to this script, and the other way around too!

asolino avatar Jul 06 '16 19:07 asolino

Thanks for the suggestion, I'll think about it!

the-useless-one avatar Jul 07 '16 08:07 the-useless-one

+1 to @asolino's comment. Ideally, I'd like to see things work with and without capitalization. Going to have to dig into the argparse library to see if there's a way of doing this.

byt3bl33d3r avatar Jul 21 '16 12:07 byt3bl33d3r

I guess case insensitiveness would be sweet, but I'm not a fan of PowerShell's capitalization (I'm a snake_case kind of guy). However, if it's a feature wanted by many people, I'll comply ;)

Cheers,

Y

the-useless-one avatar Jul 22 '16 01:07 the-useless-one

I think we can close this issue now :laughing: However, feel free to open a pull request.

:sunflower: