ClickhouseClient icon indicating copy to clipboard operation
ClickhouseClient copied to clipboard
verified publisher icon the-tinderbox

add docker feature

Open amltv opened this issue 6 years ago • 4 comments

also add .gitattributes to exclude some dev requirements

amltv avatar Aug 02 '19 12:08 amltv

Coverage Status

Coverage remained the same at 100.0% when pulling 1992a056c88051b51df4469d98f08ef9eb430829 on justcontrol-it:feature-docker into a71a451f39245c6af096fb45870e189e848927aa on the-tinderbox:master.

coveralls avatar Aug 02 '19 13:08 coveralls

Thanks for the pr! I don't fully understand what is this for. I assume this is for more easy local development and ci? If this it, can you add readme section about using it and changes to the .travis.yml please?

evsign avatar Aug 03 '19 11:08 evsign

Yes, docker needed for easy local development. Our teem use this lib, and we planned push new PR soon, docker help us this it. Sure, I add readme section. and change travis

amltv avatar Aug 05 '19 08:08 amltv

  • added xdebug, needed for coverage.
  • change docker-compose for ci compatibility.
  • add how to run tests with Docker

Please check that travis work perfect, i cant check them!!

P.S. try use phpunit/phpunit docker image but, ccat not work in container. I think it because image based on Alpine

amltv avatar Aug 09 '19 14:08 amltv