ClickhouseBuilder
ClickhouseBuilder copied to clipboard
the-tinderbox
add joinOn with multiple possibility
Old interfaces not changed, added joinOn() on builder that supports join conditions and multiple joins.
There are linting issues, some lines that I didn't change according to git, but CI server mark it as changed.
There are linting issues, some lines that I didn't change according to git, but CI server mark it as changed.
You need something like this git pull https://github.com/the-tinderbox/ClickhouseBuilder.git master.
And then resolve conficts.
Just like that, after 6 months of silence. Not sure I want to contribute any more with such an attitude. At a time it was no conflicts, but the issue with inconsistent linting of project. Do you actually want to merge it? Otherwise I see no point in solving conflicts now.
Just like that, after 6 months of silence. Not sure I want to contribute any more with such an attitude. At a time it was no conflicts, but the issue with inconsistent linting of project. Do you actually want to merge it? Otherwise I see no point in solving conflicts now.
I'm don't work on this project. I'm user who used this project 😃 I think it's very interesting issue for other users.
Sorry for the late answer. I didn't have time to look at this earlier. At the beginning, I mentioned that this feature should bring complete refactoring of the join interface, but I expected that this would mimic the laravel interface in some way.
For now, I believe there is no sense in keeping this pr open.
@ogbofjnr Sorry for the late response, I understand your disappointment, and I hope you won't be mad:) @chelsEg Sorry for the false expectations, it's open-source with no obligations after all.
