tcpdump icon indicating copy to clipboard operation
tcpdump copied to clipboard

Published 20 hours ago • verified publisher icon the-tcpdump-group

SCTP: Support printing some latest chunk types

Open CacheUseOnly opened this issue 2 years ago • 13 comments

Some new SCTP chunk types are implemented in Linux kernel but not yet supported by tcpdump to print them appropriately. These patches add corresponding supports for chunks below:

Signed-off-by: Yuxuan Luo <[email protected]>

CacheUseOnly avatar Jul 05 '22 19:07 CacheUseOnly

@guyharris could you please tell me which part of the code stops the merging process? I will update it as soon as possible.

CacheUseOnly avatar Aug 09 '22 19:08 CacheUseOnly

From the SCTP side, this patchset looks good to me.

Reviewed-by: Xin Long [email protected]

lxin avatar Aug 15 '22 13:08 lxin

Hi tcpdump maintainers, this patch is reviewed and has passed all checks, is there any concerns stopping it going to master branch?

CacheUseOnly avatar Feb 21 '23 19:02 CacheUseOnly

Thanks for preparing this PR. Each commit should have a pcap test file with eventually several output (-v, -vv, etc.). (See CONTRIBUTING.md item 6.)

fxlb avatar May 03 '23 06:05 fxlb

See CONTRIBUTING.md item 6 about TESTLIST usage.

fxlb avatar May 23 '23 14:05 fxlb

A flaw has been found regarding this PR:

The the-tcpdump-group fuzzing process has found a long or infinite loop in this code, with the following command and the attached pcap file. reading from file test_pb_extract_loop_sctp_1a.pcap, link-type EN10MB (Ethernet), snapshot length 18546948 1 [Error converting time] IP (tos 0x0, ttl 206, id 256, offset 0, flags [none], proto SCTP (132), length 16489, bad cksum ce29 (->5bfb)!) 13.20.64.1.53 > 1.1.1.0.1: sctp (1) [ASCONF-ACK] [SEQ: 0] [#0] [#0] [#0] [#0] [#0] [#0] [#0] [#0] [#0] [#0] [#0] [#0] [#0] [#0] [#0] [#0]

Will work on fixing this issue later, please do not merge this PR right now.

CacheUseOnly avatar Aug 16 '23 17:08 CacheUseOnly

This latest patch set has solved the bug mentioned above and fixed other miscellaneous issues.

CacheUseOnly avatar Dec 02 '23 21:12 CacheUseOnly

Fuzzing found a problem. Setting on draft. Private mail sent.

fxlb avatar Dec 11 '23 09:12 fxlb

Fuzzing found a problem. Setting on draft. Private mail sent.

I have not received the email, do you mind send it again to [email protected]? Appreciate that!

CacheUseOnly avatar Jan 17 '24 21:01 CacheUseOnly

send it again

Done.

fxlb avatar Jan 18 '24 15:01 fxlb

Solved a merge conflict with master branch.

CacheUseOnly avatar Mar 23 '24 16:03 CacheUseOnly

Thank you. The master branch now uses -tttt timestamps, so the new tests will need a trivial update using update-test.sh <testname>.

infrastation avatar Mar 23 '24 16:03 infrastation

Thank you. The master branch now uses -tttt timestamps, so the new tests will need a trivial update using update-test.sh <testname>.

Thanks for noticing. All the testcases .out files have been updated using ./update-test.sh.

CacheUseOnly avatar Mar 23 '24 19:03 CacheUseOnly