libpcap icon indicating copy to clipboard operation
libpcap copied to clipboard

Add new DLT_ and LINKTYPE_ for Silabs Debug Channel.

Open tecimovic opened this issue 3 years ago • 5 comments
trafficstars

Add a new LINKTYPE_, DLT_ and a DLT_CHOICE for the Silabs Debug Channel protocol.

See: https://github.com/SiliconLabs/java_packet_trace_library/blob/master/doc/debug-channel.md

tecimovic avatar Jan 05 '22 18:01 tecimovic

I see in the pull request log that there is already a PR in the queue that uses up 293. When that is merged in, let me know, I'll rebase and add a commit to change the number to whatever the actual number will finally be...

tecimovic avatar Jan 05 '22 18:01 tecimovic

Rebased...

tecimovic avatar Apr 19 '22 02:04 tecimovic

@infrastation : we have some internal work that might depend on when this is merged. It's not a deal-breaker, because we are meanwhile using one of the USER codes, so we can keep doing that, but question remains: is there anything holding this up? Any estimates when this PR might be merged?

tecimovic avatar May 04 '22 18:05 tecimovic

Rebased again.

@infrastation @guyharris: Do you need me to do anything else with this to merge it in?

tecimovic avatar Sep 18 '22 07:09 tecimovic

Do you need me to do anything else with this to merge it in?

We need you to, at minimum, answer the questions I recently asked in the-tcpdump-group/tcpdump-htdocs#27 and update your spec to provide those answers.

guyharris avatar Sep 18 '22 08:09 guyharris

@infrastation , @guyharris :

I've updated the docs as requested, I've updated the DLT number again to a later one and rebased both PRs in the two repos. Any chance we can get this merged in now?

Our organization has been using the USERx DLTs for many many months now, and we would really at this point be able to have a fixed DLT for our infrastructure work. The longer we wait, the more things will have to change here and there, so we would really appreciate this being merged, so we can then all standardize on our assigned DLT.

Thank you so much!

tecimovic avatar Nov 12 '22 14:11 tecimovic

@infrastation , @guyharris :

Any updates? If you need anything from me to get this merged in, please let me know!

Cheers, TImotej

tecimovic avatar Nov 30 '22 14:11 tecimovic

Done via commit c7cd0a1 earlier, closing.

infrastation avatar Mar 07 '23 07:03 infrastation