react-graphql-github-vanilla icon indicating copy to clipboard operation
react-graphql-github-vanilla copied to clipboard

Published 20 hours ago • verified publisher icon the-road-to-graphql

Shows an error message in case the input search is empty

Open lcnogueira opened this issue 5 years ago • 4 comments

An error occurs when the user tries to search for an empty string. So, I've done a small change that shows an error message in this case.

Please, let me know if there is something I can change to make this PR better, @rwieruch.

lcnogueira avatar Dec 25 '18 21:12 lcnogueira

Good fix. I think the same applies if the pattern organization/repository is not matched. So the error handling would be a bit more complicated here, and that's why I left it out in the first place because it doesn't really get you any further with actual GraphQL.

rwieruch avatar Dec 26 '18 04:12 rwieruch

Got it, @rwieruch. Indeed, an error is thrown if the pattern is not matched. Actually, I just wanted to contribute somehow, because I'm not used to sending PR to open source projects :smiley:. Anyway, thanks for the answer :+1:.

lcnogueira avatar Dec 26 '18 22:12 lcnogueira

Hey @lcnogueira Thanks for contributing in the first place! It really makes sense to dip one's toes into open source :)

I would love to merge the PR, but then I have to adjust the tutorial too. I keep it open for now, because when I revisit my tutorial for this application in 2019, I take your change into account 💯

Wish you all the best!

rwieruch avatar Dec 28 '18 05:12 rwieruch

Great, @rwieruch. Deal :+1:.

lcnogueira avatar Dec 28 '18 23:12 lcnogueira