website icon indicating copy to clipboard operation
website copied to clipboard
verified publisher icon the-programmers-hangout

Adjust Header heights to fit Box content

Open travisk-codes opened this issue 5 years ago • 2 comments

Changes:

  1. Constrains height of the Header component to fit the text content of the Box component (see screenshots)
  2. Fixes #339

Additional Notes:

  • Probably wanna test on your machine before commit, a lot of positioning changes.
  • Makes subjective design decisions, please offer feedback (e.g. should the Header have a min-height?

Screenshots: Before: tph-header-auto-height-1-before After: tph-header-auto-height-1-after Before: tph-header-auto-height-2-before After: tph-header-auto-height-2-after Before: tph-header-auto-height-3-before After: tph-header-auto-height-3-after Before: tph-header-auto-height-4-before After: tph-header-auto-height-4-after

travisk-codes avatar Sep 16 '20 20:09 travisk-codes

So, a lot going on here, there's a few things I'm not happy with, and I'm realizing my intent with the design and layout is not clear. I'm going to sketch out the various layouts and we can discuss the changes needed.

veksen avatar Sep 17 '20 01:09 veksen

Sorry, left this for a while, and did a conflicting PR (https://github.com/the-programmers-hangout/website/pull/376). Let me know if you'd like to go over this :D

veksen avatar Nov 12 '20 07:11 veksen