website icon indicating copy to clipboard operation
website copied to clipboard

[Bug] Light mode does not persist on title page after refresh

Open travisk-codes opened this issue 5 years ago • 6 comments

Description: When light mode is enabled, refreshing the title page will revert it back to dark mode.

To Reproduce:

  1. Enable light mode
  2. Navigate back to the title page
  3. Refresh the page

Expected Behavior: Light mode to persist after refresh

Environment:

  • OS: 5.8.6-arch1-1
  • Browser: Firefox 80.0.1 (64-bit)
  • Browser: Chromium 85.0.4183.83 (64-bit)

travisk-codes avatar Sep 07 '20 22:09 travisk-codes

The issue seems to happen on every layout, part of the layout doesn't take account the localStorage value:

https://theprogrammershangout.com/resources/javascript/

image

veksen avatar Sep 08 '20 11:09 veksen

I am able to reproduce on prod, but not on develop master. Are you?

prod steps: light mode -> refresh -> switches to dark mode with black text dev steps: light mode -> refresh -> stays in light mode

travisk-codes avatar Sep 08 '20 20:09 travisk-codes

I'm feeling like it's related to statically generated generated Gatsby assets

veksen avatar Sep 08 '20 22:09 veksen

yes 100%: https://joshwcomeau.com/gatsby/dark-mode/ improved solution from what we have

veksen avatar Sep 08 '20 22:09 veksen

I'll look into it--does it look like a major overhaul?

travisk-codes avatar Sep 08 '20 23:09 travisk-codes

No we have the majority of the groundwork already for it, it's mainly injecting some JS at runtime before Gatsby runs which is covered by the article.

veksen avatar Sep 09 '20 13:09 veksen