Michael Davis

Results 824 comments of Michael Davis

What do you think about these colors (and cursor colors in general) @enkodr? These changes could probably be applied to the other ayu themes as well.

If you're re-submitting someone else's code it's customary to credit them as a co-author in the commits: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

https://github.com/tree-sitter/tree-sitter-rust/pull/212 was merged upstream. We might want to try to solve https://github.com/helix-editor/helix/issues/6491 before merging this though: it's fairly easy to reproduce once you inject markdown into line comments and annoying...

Could you give https://github.com/helix-editor/helix/tree/handle-partial-lsp-did-save-failure a try? If you can reproduce with a smaller log, it would be interesting to see a full / "from scratch" log. This is most likely...

Not currently, see: https://github.com/helix-editor/helix/pull/997

I think the change here looks good. I wonder if it's necessary to optimize this use-case so much though? There are a few other ways that I think could be...

The _noyank commands set the register to `_` but the register isn't reset if the commands are run in a keymap sequence. These functions https://github.com/helix-editor/helix/blob/0da58656958184677b44372f72a922baacfc4940/helix-term/src/commands.rs#L2698-L2710 could be updated to save...

On second thought I would prefer we introduce an extra parameter `yank: bool` to `delete_selection_impl`: ```rust fn delete_selection(cx: &mut Context) { delete_selection_impl(cx, Operation::Delete, true); } fn delete_selection_noyank(cx: &mut Context) {...

Yep that makes sense to me. Having to symlink the binary or add an entry to `languages.toml` is not too bad of a workaround for older lldb installations

Duplicate of https://github.com/helix-editor/helix/issues/4851