trinity icon indicating copy to clipboard operation
trinity copied to clipboard

You can almost never examine the sky

Open eriktorbjorn opened this issue 5 years ago • 4 comments
trafficstars

Even when outdoors, you can rarely examine the sky:

>EXAMINE SKY
You can't see that here.

Later in the game, it will respond like this instead:

>EXAMINE SKY
You can't see it anymore.

So what's going on here? It turns out that SKY-F can redirect the action to the meteor:

	 <COND (<VERB? EXAMINE LOOK-INSIDE SEARCH>
		<COND (<IN? ,METEOR ,GLOBAL-OBJECTS>
		       <PERFORM ,V?EXAMINE ,METEOR>)
		      (T
		       <TELL CTHE ,SKY " is ">
		       <COND (<IS? ,HERE ,CHILLY>
			      <TELL "gray and overcast." CR>)
			     (<OR <IS? ,HERE ,DESERT>
				  <HERE? IN-JEEP>>
			      <TELL "dark, with scattered clouds." CR>)
			     (T
			      <TELL "bright with sunshine." CR>)>)>
		<RTRUE>)

As far as I can tell, there's never a time when METEOR isn't in GLOBAL-OBJECTS. This is how METEOR-F determines if it can be seen:

	 <COND (<IS? ,METEOR ,NOALL>
		<CANT-SEE-ANY>
		<RFATAL>)
	       (<IS? ,METEOR ,SEEN>
		<TELL ,CANT "see it anymore." CR>
		<RFATAL>)
	       (<VERB? EXAMINE WATCH WALK-TO FOLLOW FIND>
		<TELL CTHEO " is moving northeast." CR>
		<RTRUE>)

So SKY-F should presumably only redirect to the meteor when it's neither NOALL nor SEEN.

eriktorbjorn avatar Jul 24 '20 08:07 eriktorbjorn

I.e. something like this seems to work:

	 <COND (<VERB? EXAMINE LOOK-INSIDE SEARCH>
		<COND (<AND <NOT <IS? ,METEOR ,NOALL>>
		      	    <NOT <IS? ,METEOR ,SEEN>>>
		       <PERFORM ,V?EXAMINE ,METEOR>)

eriktorbjorn avatar Jul 24 '20 08:07 eriktorbjorn

This also affects MIASMA-F, which calls SKY-F.

eriktorbjorn avatar Jul 24 '20 10:07 eriktorbjorn

Note that GO-TO-SHACK will set NOALL again, but it doesn't clear SEEN. Make sure that doesn't cause any trouble.

eriktorbjorn avatar Sep 18 '20 18:09 eriktorbjorn

Even with the above fix, there are some problems:

  • Since the Vertex (ON-GNOMON) is CHILLY, the sky there is "gray and overcast" even though it's "bright with sunshine" everywhere else in that area.
  • Several outdoor rooms in the New Mexico area are not DESERT, so there the sky will be "bright with sunshine" even though it's "dark, with scattered clouds" elsewhere. This applies to at the very least TOWER-PLAT, ON-TOWER, NEYARD, SWYARD, ON-PORCH, ERANCH, IN-MILL, ON-CIST and IN-CIST. So they should probably be added to the exception that's already made for IN-JEEP.

eriktorbjorn avatar Sep 19 '20 06:09 eriktorbjorn