tarkov-dev
tarkov-dev copied to clipboard
the-hideout
Map Iconic Location Labels 🗺️
Describe the Feature Request
It would be very nice for the awesome maps to have labels on iconic locations around the map. It's very difficult sometimes to navigate and coordinate what you are near. Especially on Streets and especially to those who are new to the game.
This is something we want to add and is on our ToDo list.
But anyone can help us to speed up the process 🎉 and can be a great contribution to the project!
Current progress:
| Map | Contributor | Status |
|---|---|---|
| Customs | @colinmyers37 | 🟢 |
| Factory | @BlaneWins | 🟢 |
| Ground Zero | @cj2tech | 🟢 |
| Interchange | @BlaneWins & @brjens | 🟢 |
| Lighthouse | @BlaneWins | 🟢 |
| Reserve | @cj2tech | 🟢 |
| Shoreline | @brjens | 🟢 |
| Streets of Tarkov | @cj2tech | 🟢 |
| The Lab | @Harsh12Codes | 🟡 |
| Woods | @cj2tech | 🟢 |
How you can help! 🤸♂️
We prepared everything for its function in this PR https://github.com/the-hideout/tarkov-dev/pull/830 and we just need labels to be inserted in our maps file https://github.com/the-hideout/tarkov-dev/blob/main/src/data/maps.json by adding labels array to the interactive map (without the _):
https://github.com/the-hideout/tarkov-dev/blob/2d6ac50dbc9d5eac94a0860fcdc9c519a8be4b72/src/data/maps.json#L266-L275
Coordinates (x,z) can be found on the map itself on the bottom right, e.g. on Customs https://tarkov.dev/map/customs if we want to add a label for Dorms we position the mouse in the square between the buildings and note the coordinates
then add the coordinates to the
maps file and the common name for the location as text attribute like what we left in the example for Dorms: https://github.com/the-hideout/tarkov-dev/blob/2d6ac50dbc9d5eac94a0860fcdc9c519a8be4b72/src/data/maps.json#L271-L274
And the result will be something like this:
You can further adjust the
position to obtain the appeal you like.
For other supported properties like rotation, size and top/bottom see the original PR #830
@colinmyers37
Do we have to do all maps at once or can I make pr for each map?
We accept all contributions. So you can do one PR per map with multiple labels, or one PR with a couple of iconic locations in all maps, or any mix-and-match combination 😉 Any help is truly appreciated 👍
"I've been working on Interchange, and I've finished the outside. I have a question about the 'top' and 'bottom' properties, though. I understand they range from 10000 to -10000, and I can see for customs they have values like 2, 3, -1. How do I know which value corresponds to each layer of the map? Or, to put it differently, what are the layer values for each of Interchange's first, second, or third floor?"
"I've been working on Interchange, and I've finished the outside. I have a question about the 'top' and 'bottom' properties, though. I understand they range from 10000 to -10000, and I can see for customs they have values like 2, 3, -1. How do I know which value corresponds to each layer of the map? Or, to put it differently, what are the layer values for each of Interchange's first, second, or third floor?"
Hey, I was actually already working on interchange and quite far along. I'm not sure how we should proceed but possibly we could merge our changes together. I put in the discord that I was working on interchange, but it probably would have been ideal for me to comment it here.
As far as answering your question goes: at the top where the json for interchange starts there is an object named "layers", it includes the heights, as well as right above that there is a "heightRange" which is indicative of the ground floor.
Thanks for the help, I'll take a look. I saw you did the inside of interchange, it looks good. I'll finish up the outside, probably later today.
Nice work guys so far! 🎉
If you start working on a map, ping me here so I can mark you in the "Current progress" table 😉
Hello, I am facing an issue while working on the second level of The Lab map. I have set the top/bottom property for each label, but still, when I open the map, labels of both the first and second levels are displayed. However, when I select the second level, only second level labels are visible, and when I switch back to the first level, only first level labels are visible. Even though I have set the top/bottom property for specific layers, I am still encountering the problem when I open the map.
@Harsh12Codes it's a known bug (discovered on Factory #854) and on our todo list to be fixed next ;)
Should I create a pull request for the remaining map levels' labels or wait until the bug is fixed?
@Harsh12Codes I would keep doing labels. Better to have the info then not. Worse goes to worse people can turn off the labels entirely
