the-guild-org
Eslint fails in CI
Repos which use the eslint config published by this repo run into a problem where eslint exits with code 1. For example: https://github.com/the-guild-org/website/actions/runs/15630837568/job/44034593226
It looks like the issue is related to upgrade of eslint-plugin-unicorn.
This requires ESM dynamic import, which only works fully on ESLint 9, which is defined as a requirement (although this is missed at install?)
It was updated in the-guild configs here: https://github.com/the-guild-org/shared-config/commit/20476f5cb311f95eb96396b856e86879eb22d49b
Downgrading it from 57 to 56 should resolve the eslint failing.
I have also looked at updating to eslint 9. (Renovate tried to do this but was blocked)
I have done the migration work locally for the website repo, but it still uses 8 because that's what's defined as required by @theguild/eslint-config. So, that approach is a dead end unless @theguild/eslint-config updates to 9 also. This would require all repos that use it to then also migrate to 9 if they update their version.
The PR also includes adding back hoist patterns that were removed when moving from pnpm 9 to 10.
See https://github.com/prettier/prettier-vscode/issues/3104#issuecomment-2834447583 https://github.com/pnpm/pnpm/issues/8378