@theguild/components v7

[dimaMachina]

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 489e4586c3bb6783d879277ec477c014084d6da9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@theguild/components	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions[bot]]

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
@theguild/components	7.0.0-alpha-20241014142507-489e4586c3bb6783d879277ec477c014084d6da9	npm ↗︎ unpkg ↗︎

[github-actions[bot]]

📚 Storybook Deployment

The latest changes are available as preview in: https://8ffe282d.the-guild-docs-storybook.pages.dev

[hasparus]

Note: I broke the og-image handler by changing PRODUCTS[type].logo to new lettermarks (Slack for context).

I locked the dependency to use v6 instead of fixing it :) in hope that Monica designs new og-images anyway.

https://github.com/the-guild-org/docs/pull/1587/commits/e0e902bc3c1de56f76ffbda2cd72c14494421edb

[dimaMachina]

@hasparus can you convert these components (and others if there is) to svg instead react components ? https://github.com/the-guild-org/docs/blob/b0c713f12ca4cab844f51638026d0e4305f72dcd/packages/components/src/components/decorations.tsx

[hasparus]

@hasparus can you convert these components (and others if there is) to svg instead react components ? https://github.com/the-guild-org/docs/blob/b0c713f12ca4cab844f51638026d0e4305f72dcd/packages/components/src/components/decorations.tsx

Are you thinking about keeping them as static assets? Because if we import them as ReactComponent here, we'll effectively get the same runtime?

[dimaMachina]

Yes keeping them as assets, so we’ll have preview in GitHub and vscode

[hasparus]

@dimaMachina okay, a ~zero-runtime change refactor to have previews in the editor and GitHub convinces me.

However! what do you think about this? ⬇️

https://fotis.xyz/posts/introducing-svg-use/

We could drop those SVGs from the JS bundle and save some parse time. We'd prolly switch it for a problem with network/loading priority, but it seems worth to consider.