event-tickets icon indicating copy to clipboard operation
event-tickets copied to clipboard

[ETP-811] allow the count to update even if not public

Open ScottGarrison opened this issue 1 year ago • 2 comments

🎫 Ticket

[ETP-811]

🗒️ Description

Fixes the issues where while using tribe_tickets_attendees shortcode, 0 attendees always shows up. Did so by matching how the Block version was handling the variables, then matched the template variable being passed because it wasn't matching.

I also removed the public call to the Attendee List query as it only removes all the avatars from showing. The user being able to hide their avatar when purchasing a ticket still functions properly.

🎥 Artifacts

https://www.loom.com/share/bb1b0c481ea5411bb98a91c973cefc86

✔️ Checklist

  • [✔️] I've included a changelog entry in the readme.txt file.
  • [✔️] My code is tested.
  • [✔️] My code has proper inline documentation.

ScottGarrison avatar Aug 10 '22 15:08 ScottGarrison

We need to make sure we point to the correct branch here.

bordoni avatar Aug 31 '22 02:08 bordoni

We need to regenerate the Snapshots for Commerce Integration.

bordoni avatar Sep 27 '22 19:09 bordoni

This one is resolved with this PR: https://github.com/the-events-calendar/event-tickets-plus/pull/1383

rafsuntaskin avatar Jan 17 '23 20:01 rafsuntaskin