cascade icon indicating copy to clipboard operation
cascade copied to clipboard

Newtype deriving strategy for Show

Open the-dr-lazy opened this issue 4 years ago • 0 comments

Description

Username, EmailAddress, and Password types use newtype deriving strategy for Show instances. This was not intentional and is wrong in this case.

https://github.com/the-dr-lazy/cascade/blob/32f5991a9997353e6a9cbdd17b0ccdfb0f33ca3c/cascade-api/src/Cascade/Api/Data/Text/Username.hs#L34 https://github.com/the-dr-lazy/cascade/blob/32f5991a9997353e6a9cbdd17b0ccdfb0f33ca3c/cascade-api/src/Cascade/Api/Data/Text/EmailAddress.hs#L29 https://github.com/the-dr-lazy/cascade/blob/32f5991a9997353e6a9cbdd17b0ccdfb0f33ca3c/cascade-api/src/Cascade/Api/Data/ByteString/Password.hs#L31

the-dr-lazy avatar Feb 22 '21 19:02 the-dr-lazy