Thomas Beutlich
Thomas Beutlich
@rouault Kind reminder for review.
@rouault Once again, I propose to close this PR without merging.
If I run `pre-commit run --all-files` it will re-format all files massively (e.g., by changing the indentation level from 4 to 2), see https://github.com/OSGeo/shapelib/compare/master...thbeu:shapelib:format?expand=1 Is a .clang-format file missing in...
> pre-commit has not been setup for shapelib CONTRIBUTING.md mentions the pre-commit setup for shapelib. > When @rouault did [fe315ba](https://github.com/OSGeo/shapelib/commit/fe315bace44a770f239cfea6e9d7b9a7b319772b), I'd guess that he used https://github.com/OSGeo/gdal/blob/master/.clang-format Thanks for the hint...
Some four months later I wonder what's your feeling regarding maturity of shapelib master?
For the record: Fixed by aa7636120375d9fc6d25fc91fbe0ee4a907f9696.
I propose to also omit shputils due to #27.
> 2\. You made a ton of tiny PRs that are going to burn all of our CI minutes You'd better mark them as `[ci skip]` in the commit message....
Edit: I see that https://sourceforge.net/p/freeimage/svn/1832/ introduced this change, probably to fix https://sourceforge.net/p/freeimage/bugs/298/ (probably because of CVE-2020-21427).