Thibaut Barrère

Results 205 comments of Thibaut Barrère

Ok, thanks for the confirmation! I have implemented a quick fix and we will generalise it. Apparently we have other things needed even for HTTPoison anyway (https://github.com/etalab/transport-site/blob/02c9c8c213758019cfb6525aac8cb9bfde09d383/apps/transport/lib/transport/import_data.ex#L334-L359). Indeed I wonder...

I quite seem to recall I stumbled on cases where this lead to troubles. I will try to report back with précise urls. Le mar. 14 nov. 2023 à 21:22,...

I have extracted a list of urls from our pool of resources, filtering where "encoded url" != "the url itself" (and filtering out the "pipe" case which we have already...

@wojtekmach I did a bit of investigation (first in our app & with the code at the top of this issue), but ultimately I bisected it here (see below). The...

@wojtekmach maybe it would be worth just adding a test in the codebase with "https://httpbin.org/anything?a[b]=1|2", so that we ensure it does not change unexpectedly in the future? Just an idea....

Yes, the change of behaviour is linked to the pipe indeed, as @AntoineAugusti pointed out! (thank you!)

> Right, my bad. I'm able to reproduce this locally: No problem - the url includes too many weird characters for a url anyway :-) Happy to help out if...

@wojtekmach thanks for diving into this! Pretty wild indeed, and I would be happy to ensure we have some form of non-regression testing on that. FYI we've upgraded on our...

One frequently asked question I've seen (last one today at a NeTEx training we're holding) is very simple: how to advertise a name change, can I use version for that?...

Update: the meeting occurred, I've updated the top-level plan on which we all agreed. Re branches, we should probably make a little session to come to an agreement (& turn...