Thomas Dy
Thomas Dy
Not stale
It's been a while so I might be mistaken, services can handle partitioning promtail to distributor communication which is good, but it does not address distributor to ingester communication. While...
It seems that's from https://github.com/tridactyl/tridactyl/blob/50f19a34fc5f1006a7fccd93e35bca41eb011942/src/excmds.ts#L1320 the redhat page seems to fire synthetic `load` events so maybe an `isTrusted` check is necessary for that, or maybe better marking it as `once`.
The docs seem to suggest it should be on `window` and not `document` instead https://developer.mozilla.org/en-US/docs/Web/API/Window/load_event
> Unlike #256, I don't believe this will cause a performance regression. Upon further thought, this might cause the same performance regression as #256. It's a bit hard to tell...
Hm, looking at the possible flows, I'm not really sure what could be the cause of the performance regression. Logs from the affected user would have been nice to have...
Have you tried using this PR or #256 to see if it fixes it for you?
Hm, regarding the performance issues, I think the only thing that's not cached is a negative result for `loadRepository`. This would only be an issue if **Github Commiter Authorization Strategy**...
Thanks for checking!