kirby-git-content icon indicating copy to clipboard operation
kirby-git-content copied to clipboard

display author in list of commits

Open hariom147 opened this issue 1 year ago • 3 comments

Hi, first of all thanks for this plugin. This is only the second time I'm contributing a PR, so please excuse any mistakes 🙂

I added the author info for my own purposes and thought in might benefit others as well. I also tried using your coding-patterns...

This is what it looks like: Screenshot 2024-08-24 at 18 26 49

hariom147 avatar Aug 24 '24 16:08 hariom147

Thank you @hariom147, it looks good (especially for your second PR)! I actually had the same idea and have already included it in a more elaborate extension of the panel view: https://github.com/thathoff/kirby-git-content/blob/commit-by-pages/js/components/GitContent.vue#L113

But your PR is quite small and my changes will take some time to finish, so I'm looking forward to testing and merging this!

One wish: I think we can safely add this feature without an option, as I cannot imagine a case where this information should be hidden. This removes some of the complexity of your changes (even if they are small) and does not introduce a new option. Would you mind changing the feature so that it does not require an option?

thathoff avatar Aug 28 '24 15:08 thathoff

Thanks for the Kind words - with the Vue template part I had some help using Cursor 🤠

I am traveling at the moment ~~and will update the PR next weekend~~.

Looking forward to the improvements you're working on...

hariom147 avatar Aug 28 '24 18:08 hariom147

Would you mind changing the feature so that it does not require an option?

I just found some time to make the changes and force-pushed to overwrite the last commit. I hope I did it the right way...

hariom147 avatar Aug 28 '24 19:08 hariom147