quine icon indicating copy to clipboard operation
quine copied to clipboard

chore: Use dropRepeated in pekko stream

Open He-Pin opened this issue 4 months ago • 7 comments

Description

Use dropRepeated in pekko stream

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Test A
  • [ ] Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

He-Pin avatar Sep 13 '25 09:09 He-Pin

Hi @He-Pin, Thanks for your contribution!

I saw you closed this PR. Possibly was that due to the CI failure? I investigated that CI failure and found that it was a random failure, unrelated to your change. Sorry about that. Is that you reason you closed this PR? If so, would could consider re-opening it now that it's passing CI.

nescohen avatar Sep 15 '25 18:09 nescohen

Yes, Iwas expecting it works but it fails.

He-Pin avatar Sep 15 '25 18:09 He-Pin

I think it has something to do with my changes. After all, this project is very important. Although I think it should be correct, I'm not very familiar with the project, so I closed it. Thank you for taking the time to answer me.

He-Pin avatar Sep 15 '25 18:09 He-Pin

I was planning to add Sink.count too.

He-Pin avatar Sep 15 '25 18:09 He-Pin

Ah, that makes sense. I maintain these tests, and I don't think it was related to your change. That test in particular has given several random failures in the past.

nescohen avatar Sep 15 '25 18:09 nescohen

I was planning to add Sink.count too.

That sounds great, thank you 🙏

nescohen avatar Sep 15 '25 18:09 nescohen

Thank you too. I usually develop Java. To be honest, it's really not very easy to use sometimes, but there are indeed more powerful abstractions. I also saw the scenes from your project. Thank you for making such an excellent project open-source and allowing me to learn.

He-Pin avatar Sep 15 '25 18:09 He-Pin