thanos icon indicating copy to clipboard operation
thanos copied to clipboard

Published 20 hours ago • verified publisher icon thanos-io

*: bump Go to 1.23.x

Open GiedriusS opened this issue 1 year ago • 2 comments

Bump Go to 1.23.x. The main goal is to be able to take advantage of the new unique package to intern strings.

GiedriusS avatar Sep 13 '24 09:09 GiedriusS

Blocked on https://github.com/minio/minio/issues/20435

GiedriusS avatar Sep 13 '24 13:09 GiedriusS

It seems like we will also have to wait until https://github.com/golang/go/commit/21ac23a96f204dfb558a8d3071380c1d105a93ba lands in a version because otherwise, it is easy to trigger a panic since it retains the original string right now.

GiedriusS avatar Sep 16 '24 14:09 GiedriusS

Seems this was superseded by https://github.com/thanos-io/thanos/pull/7833

machine424 avatar Dec 19 '24 09:12 machine424