thanos icon indicating copy to clipboard operation
thanos copied to clipboard

Ruler UI: `alert.query-template` is not honored inside the Rules UI

Open jkroepke opened this issue 1 year ago • 3 comments
trafficstars

Thanos, Prometheus and Golang version used:

Object Storage Provider:

Azure

What happened:

Clicking inside the Ruler UI > Rules > Any Expressions, the default value /graph?g0.expr= for building the querier URL will be used instead the template from alert.query-template. I'm talking about the links in the screen below:

image

Ref: https://github.com/thanos-io/thanos/blob/968899fabc7d66e764cf5bcd500cae26dcdd1103/pkg/ui/react-app/src/utils/index.ts#L290

What you expected to happen:

If I define alert.query-template, if UI should take care about it.

How to reproduce it (as minimally and precisely as possible):

  1. Start Ruler with any alert.query-template value.
  2. Setup Rules
  3. Go to Ruler UI and observe that alert.query-template is not used.

Full logs to relevant components:

Anything else we need to know:

jkroepke avatar Apr 15 '24 11:04 jkroepke

@jkroepke Hey, I'm looking to some golang development and I was wondering if I could pick this up as a first issue into golang in general.

Norman-Lee avatar Apr 29 '24 01:04 Norman-Lee

@Norman-Lee I guess the issue is more typescript related as golang.

jkroepke avatar Apr 29 '24 06:04 jkroepke

@jkroepke Oh rip, I'll probably pass on this then. Thanks for letting me know.

Norman-Lee avatar Apr 30 '24 02:04 Norman-Lee

This can be closed, as fix has been released.

saswatamcode avatar Jun 13 '24 14:06 saswatamcode