thanos icon indicating copy to clipboard operation
thanos copied to clipboard

Sidecar Flag: Random delay before upload blocks on sidecar

Open Vperiodt opened this issue 1 year ago • 3 comments

  • [x] I added CHANGELOG entry for this change.
  • [ ] Change is not relevant to the end user.

Changes

#7184 Implemented the logic to sleep for a random time between 0 and the specified jitter before uploading blocks.Defined a flag to specify the maximum random delay before uploading blocks.

Verification

Vperiodt avatar Mar 26 '24 16:03 Vperiodt

Hello ! @yeya24 PTAL

Vperiodt avatar Mar 26 '24 17:03 Vperiodt

Thanks for this contribution. I am curious what is the benefit to adding jitter to the upload.

Thanks for this contribution. I am curious what is the benefit to adding jitter to the upload.

adding jitter prevents network blockage as it introduces random delays to the uploads

Vperiodt avatar Apr 04 '24 07:04 Vperiodt

Hello! @fpetkovski @yeya24 resolved the reviews PTAL!

Vperiodt avatar Apr 04 '24 12:04 Vperiodt